Skip to content

added 'pr' to pressure field #20#21

Merged
ocefpaf merged 1 commit intopyoceans:masterfrom
Grupo-de-Oceanografia-Costeira:pressure
May 2, 2017
Merged

added 'pr' to pressure field #20#21
ocefpaf merged 1 commit intopyoceans:masterfrom
Grupo-de-Oceanografia-Costeira:pressure

Conversation

@vinisalazar
Copy link
Copy Markdown

on line 202 of ctd/ctd.py we added 'pr' to the possible pressure field names, so it is compatible with older models of the SeaBird MicroCat.

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented May 2, 2017

@vinisalazar and @arnaldorusso unfortunately I am not doing a lot of operational oceanography as I would like. So if you guys are relying on this package maybe I should add one (or both) as a contributor with merge rights here.

The fix here is OK but a more permanent solution would be to add an option, which defaults to None and uses those hardcoded values, but that allows a user input name for the pressure column.

PS: The failures are unrelated to this PR and I will take a look at them later.

@ocefpaf ocefpaf merged commit cc9b2fc into pyoceans:master May 2, 2017
@richardsc
Copy link
Copy Markdown

I know this is a specific case, but in our R/oce package we have done a fair bit of work to try and recognize many of the different names that things can have in SBE files. You can see a summary list at the link below, with a checklist that was derived from an SBE manual. Note that all the possible units are not exhaustively implemented in our package, but the checklist and the manual might be useful for future additions of possible fields that might be encountered in various different SBE products.

dankelley/oce#962

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented May 2, 2017

That is a cool solution @richardsc! Thanks for sharing!

@vinisalazar are you game to try to implement something similar here 😉

@vonopr vonopr mentioned this pull request May 27, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants